perf: improve to_file_path() #1018
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Jan 27, 2025
| } else { | ||
| Vec::new() | ||
| }; | ||
| let mut bytes = Vec::with_capacity(estimated_capacity); |
There was a problem hiding this comment.
Before 1,000 iterations within an iteration:
test url_to_file_path ... bench: 202,125 ns/iter (+/- 12,207)
After:
test url_to_file_path ... bench: 127,257 ns/iter (+/- 4,782)
dsherret
commented
Jan 27, 2025
| host: Option<&str>, | ||
| segments: str::Split<char>, | ||
| ) -> Result<PathBuf, ()> { | ||
| file_url_segments_to_pathbuf_windows(host, segments) | ||
| file_url_segments_to_pathbuf_windows(estimated_capacity, host, segments) | ||
| } | ||
|
|
||
| // Build this unconditionally to alleviate https://github.com/servo/rust-url/issues/102 | ||
| #[cfg(feature = "std")] | ||
| #[cfg_attr(not(windows), allow(dead_code))] | ||
| fn file_url_segments_to_pathbuf_windows( |
There was a problem hiding this comment.
Before 1000 iterations within an iteration:
test url_to_file_path ... bench: 437,555 ns/iter (+/- 11,519)
After:
test url_to_file_path ... bench: 119,461 ns/iter (+/- 5,927)
dsherret
commented
Jan 27, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1018 +/- ##
=======================================
Coverage ? 80.32%
=======================================
Files ? 24
Lines ? 4233
Branches ? 0
=======================================
Hits ? 3400
Misses ? 833
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
Opened #1019 for the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces some heap allocations and pre-allocates the vector for building the string.