Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementations rework #207

Merged
merged 27 commits into from
Nov 22, 2024
Merged

Implementations rework #207

merged 27 commits into from
Nov 22, 2024

Conversation

sewcio543
Copy link
Owner

@sewcio543 sewcio543 commented Nov 17, 2024

First PR with soupsavvy major version 1.0.0 rework, paving the way implementation-agnostic selectors.
Implementation of selectors does not depend on bs4, but on another layer of abstraction which is IElement - interface, that defines all functionality used across package.

All nodes, which implementation is supported need to be wrapped with appropriate element, that implements IElement interface and enable the use of selectors and all soupsavvy functionality.

Currently supported implementations are:

  • bs4
  • lxml
  • selenium

@sewcio543 sewcio543 changed the base branch from main to dev/1.0.0 November 17, 2024 23:56
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev/1.0.0@c50b30d). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev/1.0.0      #207   +/-   ##
=============================================
  Coverage             ?   100.00%           
=============================================
  Files                ?        36           
  Lines                ?      1261           
  Branches             ?       197           
=============================================
  Hits                 ?      1261           
  Misses               ?         0           
  Partials             ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@sewcio543 sewcio543 added breaking This pull request has potentially huge inpact on package feature New package feature labels Nov 22, 2024
@sewcio543 sewcio543 merged commit 0405ec4 into dev/1.0.0 Nov 22, 2024
25 checks passed
@sewcio543 sewcio543 deleted the selectors/ielement branch November 22, 2024 15:31
@sewcio543 sewcio543 linked an issue Dec 22, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This pull request has potentially huge inpact on package feature New package feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for other structures
1 participant