Use string as scope #286
Closed
Use string as scope #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a list of scopes was not spec compliant: thephpleague/oauth2-server#1469 With an update of our oauth lib this is no longer supported, leading to fails in the ATS: shopware/shopware#5986
pweyck
reviewed
Jan 24, 2025
| @@ -89,7 +89,7 @@ export class AdminApiContext { | |||
| grant_type: 'client_credentials', | |||
| client_id: options.client_id, | |||
| client_secret: options.client_secret, | |||
| scope: ['write'], | |||
| scope: 'write', | |||
There was a problem hiding this comment.
we need to support older shopware versions (at least the LTS), so we should try both variations, if we can't detect the version (I believe that is only possible after auth)
There was a problem hiding this comment.
I know, it should have always worked to provide plain string therefore there should be no need to switch the behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a list of scopes was not spec compliant: thephpleague/oauth2-server#1469
With an update of our oauth lib this is no longer supported, leading to fails in the ATS: shopware/shopware#5986