Fix 3 simple bugs #82
Conversation
- The regex for matching request, was not considering arrays in the request JSON - For request with a request body, canned was checking content type to exactly match `application/json`, which is not good as browsers may sent charset as well with the content type. - For matching request and filters with more accuracy, we were converting the values of all keys in request to string before comparing, but this was being done wrong as it was creating string of Objects and arrays as well, which it shouldn’t
|
@sideshowcoder I forgot to create a new feature branch for this PR, but i guess that is ok, please review and let me know if you need any changes. If you can release a revision in npm, with these fixes today, it would be really cool 💯 |
|
@sideshowcoder I am also working in something similar to #56, but my requirement being more of like having a filter like which will basically proxy matching request to the url and then provide the response from the url back. Would this be something interesting for you? |
| @@ -87,6 +87,16 @@ function getContentType(mimetype){ | |||
| return Response.content_types[mimetype] | |||
| } | |||
|
|
|||
| function traverseAndSanitise(object) { | |||
There was a problem hiding this comment.
Sorry just a typo traverseAndSanitize
There was a problem hiding this comment.
@sideshowcoder oops, fixing right away
There was a problem hiding this comment.
Maybe call it stringifyValues because that is what it does I think.
There was a problem hiding this comment.
@sideshowcoder done
| metaData.request[key] = String(value) | ||
| }) | ||
|
|
||
| traverseAndSanitise(metaData.request); |
There was a problem hiding this comment.
Calling it stringifyValues makes this comment reduantant :) so we can remove it.
There was a problem hiding this comment.
@sideshowcoder okey dokey 👍 , 1 min
There was a problem hiding this comment.
@sideshowcoder done
|
Yes such a change feature as proxy would be quite valuable! thank you :) I will try to get out a new version to npm today :) |
|
I added you as a collaborator on canned as you are already adding a bunch of features and fixes :) |
|
@sideshowcoder cool, thanks, thats nice 👍 |
|
out on npm. |
|
@sideshowcoder thanks for the quick publish, much appreciated 👍 |
request JSON
exactly match
application/json, which is not good as browsers maysent charset as well with the content type.
converting the values of all keys in request to string before
comparing, but this was being done wrong as it was creating string of
Objects and arrays as well, which it shouldn’t