Fix passing arguments with spaces to external commands #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously nothing would be passed to the external command if the query was empty, but the changes in skim-rs#217 caused it to instead pass an empty string. This keeps compatibility with the previous behaviour
|
Given how far we have diverged since this was opened, I am sorry but I need to ask you to resolve the conflicts and merge master into this before we can review it properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surrounds the parameter passed to the
-c/--commandexternal executable with'..'and escapes the string appropriately. This means that when doing interactive grep using ripgrep you can typepub fn my_function_name- a very commonly-needed query - and get the correct result.I assume this wasn't previously done for performance reason, so PR uses my lazy string replacement crate to avoid intermediate allocations. The speed should be pretty good despite escaping, surrounding with quotes and then replacing the
{}(or other-Istring) in the command parameter since that's all done in one pass.From testing on my own computer the speed is very good, but that's just anecdotal evidence.