Qt: Fix event forwarding for native popups #7609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that popup menus can handle hover events. This also remove some of the code in the qt backend that used the private API
ogoffart
commented
Feb 11, 2025
internal/backends/qt/qt_window.rs
Outdated
| auto pos = event->pos(); | ||
| if (auto p = dynamic_cast<const SlintWidget*>(parent()); p && !rect().contains(pos)) { | ||
| while (auto pp = dynamic_cast<const SlintWidget*>(p->parent())) { | ||
| if (p->rect().contains(p->mapFromGlobal(event->globalPosition().toPoint()))) |
There was a problem hiding this comment.
QMouseEvent::globalPosition is new in Qt6. But QMouseEvent::globalPos is deprecated.
I guess i need to make a #ifdef dance to avoid the deprecated warning.
tronical
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that popup menus can handle hover events.
This also remove some of the code in the qt backend that used the private API