-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [NOT MAINTAINED] Show image thumbnail functionality implemented #23
base: master
Are you sure you want to change the base?
Conversation
Hey @manishsaraan Also, please excuse me for the changes I recently did regarding logo and disclaimer changes. I didn't notice your changes before it and hence there are some conflicts which need to be resolved in this PR. Awesome work @manishsaraan 👍 |
It would be great if this feature can be toggled. Otherwise, it's perfect. |
Thanks for feedback @softvar . I will add enable thumbnail option in option.html and it will be disabled by default. Also do i need to update the current text for setting from Add Github Token to some other text as we are not only adding token there? |
I would rather say thumbnail should be enabled by default and show a tooltip on hover that you can disable this in options otherwise no one would be aware of such a good feature. |
Thanks for suggestion @softvar .I will update the pr accordingly. |
Hey @manishsaraan , Any update you would like to share? |
@softvar its been while since I last updated this pr. I need to review changes again and will raise pr asap. |
@softvar i have implemented the functionality to show image thumbnails for #22 . I am not supporting svg for now and also set the limit to max 100 images in directory. So if there are more than 100 images(not total files) than no preview will be visible. Please have a look if its right way to do it.
Screenshot: https://prnt.sc/kdax67