Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copied changes of shekela:bugfix/NUI-6241-drilldown-empty-values #720

Closed
wants to merge 2 commits into from

Conversation

KleinMichalGit
Copy link
Contributor

Frontend Pull Request Description

copied changes of shekela:bugfix/NUI-6241-drilldown-empty-values from #719

"Hey, I created function which renders the specific values for undefined or false values. In the case the data contains null, undefined, false and etc. In case of undefined or null data was not rendering values after null or undefined because those values do not have properties, so it was error in console, so I mapped data and when I was rendering the data I turned undefined or null values to string "undefined" or "null" and it continued working. I render string and "-" for false or undefined values. Strings can be changed to specific values whatever will be necessary from function. I run spec.ts file also with additional case and it doesn't break any other code. There are no errors in console."

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have updated change log
  • I have been following Definition of done
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new lint warnings
  • New and existing unit tests pass locally and on CI with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

image
image

Additional Context (if necessary)

@KleinMichalGit
Copy link
Contributor Author

Since Helpdesk is no longer providing write access to Nova repo for new interns and CircleCI does not recognize PRs from forked repositories, I copied changes from #719 in order for @shekela to merge his PR. Iam not the original author of the source code in this PR it only copies changes by @shekela

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants