Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnsiConsole.Write(string value) uses format string #1516

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BlazeFace
Copy link
Contributor

@BlazeFace BlazeFace commented Apr 14, 2024

Restore parity between write and write line

fixes #1495 #1387

  • I have read the Contribution Guidelines
  • I have commented on the issue above and discussed the intended changes
  • A maintainer has signed off on the changes and the issue was assigned to me
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

Updating Write to be inline with the functionality of WriteLine where string format is only used when an args object array is included in the method call.


Please upvote 👍 this pull request if you are interested in it.

…tring to restore parity between write and write line
@BlazeFace BlazeFace changed the title Fixing #1495 AnsiConsole.Write(string value) uses format string Fixing #1495 and #1387 AnsiConsole.Write(string value) uses format string Apr 14, 2024
@github-actions github-actions bot added the ⭐ top pull request Top pull request. label Apr 18, 2024
@FrankRay78 FrankRay78 self-requested a review November 13, 2024 10:41
@FrankRay78 FrankRay78 assigned FrankRay78 and BlazeFace and unassigned BlazeFace Nov 13, 2024
@FrankRay78 FrankRay78 added this to the 0.50 milestone Nov 13, 2024
@FrankRay78
Copy link
Contributor

I can see it's a small change, but I haven't reviewed it properly yet. Added to my queue and I'll see about getting this one over the line for you @BlazeFace. Then I think you won't have any outstanding PR's languishing. I'll be in touch soon.

@FrankRay78 FrankRay78 linked an issue Nov 13, 2024 that may be closed by this pull request
@FrankRay78 FrankRay78 changed the title Fixing #1495 and #1387 AnsiConsole.Write(string value) uses format string AnsiConsole.Write(string value) uses format string Nov 13, 2024
@FrankRay78 FrankRay78 assigned BlazeFace and unassigned FrankRay78 Nov 13, 2024
@patriksvensson patriksvensson modified the milestones: 0.50, 0.51 Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ top pull request Top pull request.
Projects
Status: PR 📬
3 participants