Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes Search in SelectionPrompt to accept Space Key as text #1601

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DerReparator
Copy link

fixes #1536

  • I have read the Contribution Guidelines
  • I have commented on the issue above and discussed the intended changes
  • A maintainer has signed off on the changes and the issue was assigned to me
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

This changes the hotkeys for the single Selection (not the Multi Selection) in such a way that the Space key does not select the option anymore but instead is typed into the search.

If the search is not enabled for the Selection, Space still selects the current option.


Please upvote 👍 this pull request if you are interested in it.

@DerReparator
Copy link
Author

DerReparator commented Aug 8, 2024 via email

@github-actions github-actions bot added the ⭐ top pull request Top pull request. label Sep 2, 2024
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
@github-actions github-actions bot added ⭐ top pull request Top pull request. and removed ⭐ top pull request Top pull request. labels Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ top pull request Top pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search doesn't work properly in selection prompts
2 participants