Merge pull request #156 from sproogen/feature/misc-updates

Removed google+ link and some config & readme updates
sproogen · Jan 15, 2022 · 4a4477c · 4a4477c
2 parents aceb107 + 82718a8
commit 4a4477c
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 16 deletions.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -13,11 +13,12 @@ We use github to host code, to track issues and feature requests, as well as acc
 ## We Use [Github Flow](https://guides.github.com/introduction/flow/index.html), So All Code Changes Happen Through Pull Requests
 Pull requests are the best way to propose changes to the codebase (we use [Github Flow](https://guides.github.com/introduction/flow/index.html)). We actively welcome your pull requests:
 
-1. Fork the repo and create your branch from `master` for bug fixes and `develop` for new features.
-2. If you've added code that should be tested, add tests.
+1. Fork the repo and create your branch from `master`.
+2. If you've added/changed anything that relates to the config, please update relevant config files in the `_test` directory.  
+    These are used to run tests and build a review app for the PR.
 3. If you've changed APIs, update the documentation.
 4. Ensure the test suite passes.
-6. Issue that pull request!
+5. Issue that pull request!
 
 ## Any contributions you make will be under the MIT Software License
 In short, when you submit code changes, your submissions are understood to be under the same [MIT License](http://choosealicense.com/licenses/mit/) that covers the project. Feel free to contact the maintainers if that's a concern.

diff --git a/_config.yml b/_config.yml
@@ -30,7 +30,6 @@ linkedin_username: jekyll
 xing_username: jekyll
 pinterest_username: jekyll
 youtube_username: jekyll
-googleplus_username: +jekyll
 orcid_username: 0000-0000-0000-0000
 googlescholar_username: D847cGsAAAAJ
 

diff --git a/_includes/header.html b/_includes/header.html
@@ -83,13 +83,6 @@ <h2>{{ site.title | escape }}</h2>
             </a>
           </li>
         {%- endif -%}
-        {%- if site.googleplus_username -%}
-          <li>
-            <a target="_blank" href="https://plus.google.com/{{ site.googleplus_username| escape }}" class="button button--sacnite button--round-l">
-              <i class="fab fa-google-plus" title="Google plus link"></i>
-            </a>
-          </li>
-        {%- endif -%}
         {%- if site.orcid_username -%}
           <li>
             <a target="_blank" href="https://orcid.org/{{ site.orcid_username | escape }}" class="button button--sacnite button--round-l">

diff --git a/_test/_config-version-1.yml b/_test/_config-version-1.yml
@@ -21,7 +21,6 @@ linkedin_username: jekyll
 xing_username: jekyll
 pinterest_username: jekyll
 youtube_username: jekyll
-googleplus_username: +jekyll
 orcid_username: 0000-0000-0000-0000
 googlescholar_username: D847cGsAAAAJ
 

diff --git a/_test/_config-version-2.yml b/_test/_config-version-2.yml
@@ -30,7 +30,6 @@ linkedin_username: jekyll
 xing_username: jekyll
 pinterest_username: jekyll
 youtube_username: jekyll
-googleplus_username: +jekyll
 orcid_username: 0000-0000-0000-0000
 googlescholar_username: D847cGsAAAAJ
 
@@ -129,8 +128,6 @@ references_title: References on request
 # theme: modern-resume-theme (Use this is you are hosting your resume yourself)
 # remote_theme: sproogen/modern-resume-theme (Use this if you are hosting your resume on GitHub)
 
-data_dir: _test/_data
-
 include:
  - _test
 

diff --git a/app.json b/app.json
@@ -14,5 +14,5 @@
   "name": "modern-resume-theme",
   "scripts": {
   },
-  "stack": "heroku-18"
+  "stack": "heroku-20"
 }