update toolchain and revert llvm issue patch #1004
Closed
+39
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ohad-starkware
changed the title
ohad-starkware
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1004 +/- ##
==========================================
- Coverage 92.92% 92.92% -0.01%
==========================================
Files 105 105
Lines 14243 14242 -1
Branches 14243 14242 -1
==========================================
- Hits 13236 13235 -1
Misses 927 927
Partials 80 80 ☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: ec15a53 | Previous: 394f839 | Ratio |
|---|---|---|---|
iffts/simd ifft/22 |
12692101 ns/iter (± 113987) |
6272224 ns/iter (± 205833) |
2.02 |
merkle throughput/simd merkle |
30917673 ns/iter (± 650900) |
13123349 ns/iter (± 484950) |
2.36 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @shaharsamocha7
ohad-starkware
force-pushed
the
ohad/update_toolchaon_06_02
branch
from
056648f to
572d70a
Compare
ohad-starkware
force-pushed
the
ohad/update_toolchaon_06_02
branch
from
572d70a to
ec15a53
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 15 files reviewed, 1 unresolved discussion (waiting on @ohad-starkware)
a discussion (no related file):
They fixed your issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.