feat: add math/base/special/wrapf
#3055
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gunjjoshi, could you review this PR? Some checks are failing, need guidance for it. |
gunjjoshi
reviewed
Nov 3, 2024
| if ( vc < minc ) { | ||
| vc += delta * ( stdlib_base_truncf( ( minc - vc ) / delta ) + 1.0 ); | ||
| } | ||
| return minc + ( fmodf( vc - minc, delta ) ); |
There was a problem hiding this comment.
@gururaj1512 The fmodf which is being used here, is not being included at the top. We are currently missing the implementation of fmodf. You'll need to include it once we have added fmodf.
There was a problem hiding this comment.
@gunjjoshi, Thanks for clarifying
There was a problem hiding this comment.
@gururaj1512 fmodf (added by @gunjjoshi in #3059) has now landed, so this branch can be rebased on the latest code on develop and updated to make use of it.
1 task
Planeshifter
added a commit
that referenced
this pull request
Nov 10, 2024
PR-URL: #3059 Ref: #2997 Ref: #3055 Ref: #649 Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]> Signed-off-by: Gunj Joshi <[email protected]> Signed-off-by: Philipp Burckhardt <[email protected]>
aayush0325
pushed a commit
to aayush0325/stdlib
that referenced
this pull request
Nov 11, 2024
PR-URL: stdlib-js#3059 Ref: stdlib-js#2997 Ref: stdlib-js#3055 Ref: stdlib-js#649 Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]> Signed-off-by: Gunj Joshi <[email protected]> Signed-off-by: Philipp Burckhardt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #649
Description
math/base/special/wrapf, which would be the single-precision equivalent for math/base/special/wrap.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers