Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update decoder.ts #224

Open
wants to merge 59 commits into
base: master
Choose a base branch
from
Open

Update decoder.ts #224

wants to merge 59 commits into from

Conversation

icocoding
Copy link

fix: Underrun error on COMPLETED_ORDER: End of message reached. Please report to https://github.com/stoqey/ib - code: 505 - reqId: -1

Copy link

codeclimate bot commented Sep 23, 2024

Code Climate has analyzed commit 6d7a6de and detected 0 issues on this pull request.

View more on Code Climate.

@rylorin
Copy link
Member

rylorin commented Nov 10, 2024

Hello,
Thanks for your PR.
Basically I don't understand the reason behind most of your changes; and your changes on decoder.ts hide the problem instead of fixing it. Having an exception raised when we identify inconsistent data is what we want.
May I suggest you to update your PR?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants