Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: align gh actions and dependabot with ecosystem standard #7

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

edodusi
Copy link
Contributor

@edodusi edodusi commented Jan 16, 2025

With this dependabot will create a single PR "security-updates" with multiple patch updates do deps.
Also a new GH Action will automatically approve any dependabot PR so they can be merged without further approvals.

@silasjoisten
Copy link
Collaborator

Cool ! :)

@silasjoisten
Copy link
Collaborator

@edodusi to be honest i like the small PRs more of dependabot because its easier to rollback and determine when there was a breaking change in a vendors lib. just to make sure.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.35%. Comparing base (9098c90) to head (b4b1337).

Additional details and impacted files
@@            Coverage Diff            @@
##             master       #7   +/-   ##
=========================================
  Coverage     97.35%   97.35%           
  Complexity      250      250           
=========================================
  Files            59       59           
  Lines          1021     1021           
=========================================
  Hits            994      994           
  Misses           27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edodusi
Copy link
Contributor Author

edodusi commented Jan 17, 2025

@silasjoisten I get your point. With this one dependabot will only group patch updates, I know that even a patch can potentially break things but to me this is safe enough and it saves some time. And if we later find that this requires more effort from us than what it saves, we can always change strategy. What do you think?

@edodusi edodusi merged commit e4f305d into master Jan 17, 2025
4 checks passed
@edodusi edodusi deleted the chore/dependabot-strategy branch January 17, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants