Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/custom oauth callback class #11069

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

YuanShisong
Copy link

Type of change

Select the type of your PR

  • Enhancement / new feature

Description

For kafka-connect there's a default OAUTH_CALLBACK_CLASS: sasl.login.callback.handler.class=io.strimzi.kafka.oauth.client.JaasClientOauthLoginCallbackHandler for SASL_MECHANISM: oauth. There need be a param for customize OauthCallbackHandler for customer who wants to use there own implemented OauthCallbackHandler.

@scholzj
Copy link
Member

scholzj commented Jan 23, 2025

The type OAuth authentication is using the Strimzi OAuth library. I do not think there is any expectation to use it with some custom callback classes.

@scholzj
Copy link
Member

scholzj commented Jan 23, 2025

Just to add to my previous comment:

  • I don't think this PR really does anything from what you describe in the description.
  • Should we support something like a custom OAuth implementation, it would need to be implemented for all compoenents - for example for the Bridge, Mirror Maker 2 etc.
  • The right way to do it would probably start by writing a proposal (https://github.com/strimzi/proposals) for some type: custom authentication option rather than changing the Strimzi OAuth authentication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants