Add uapi bindings to elf.h #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
reviewed
Dec 18, 2024
There was a problem hiding this comment.
Looks good overall. Could you add a comment somewhere explaining the differences between the existing "elf" feature and module and this new one? The existing one is manually written because I didn't notice that Linux had an elf.h that we could generate bindings for, and the existing one has some mild abstractions like Elf_Rel which correspond to the *_Rel type for the target platform.
|
Thanks! |
sunfishcode
pushed a commit
that referenced
this pull request
Jan 7, 2025
* Add uapi bindings to elf.h * Add note on `elf_uapi` and `elf` differences
sunfishcode
pushed a commit
that referenced
this pull request
Jan 7, 2025
* Add uapi bindings to elf.h * Add note on `elf_uapi` and `elf` differences
sunfishcode
pushed a commit
that referenced
this pull request
Jan 8, 2025
* Add uapi bindings to elf.h * Add note on `elf_uapi` and `elf` differences
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NT_*constants were not exposed inelfmodule