Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSA Support #88

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

RSA Support #88

wants to merge 8 commits into from

Conversation

dscreve
Copy link

@dscreve dscreve commented Jan 28, 2025

RSA Support

0xTim
0xTim requested changes Jan 28, 2025
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Some initial comments

Sources/WebAuthn/Ceremonies/Shared/COSE/COSEAlgorithmIdentifier.swift Outdated Show resolved Hide resolved
Sources/WebAuthn/Ceremonies/Shared/COSE/COSEAlgorithmIdentifier.swift Outdated Show resolved Hide resolved
Sources/WebAuthn/Ceremonies/Shared/CredentialPublicKey.swift Show resolved Hide resolved
Sources/WebAuthn/Ceremonies/Shared/CredentialPublicKey.swift Outdated Show resolved Hide resolved
Tests/WebAuthnTests/Utils/TestModels/TestRSAKeyPair.swift
Comment on lines +1 to +6
//
// TestRSAKeyPair.swift
// swift-webauthn
//
// Created by David Scrève on 27/01/2025.
//
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be the license header

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in next commit

Tests/WebAuthnTests/Utils/TestModels/TestRSAKeyPair.swift Outdated Show resolved Hide resolved
Tests/WebAuthnTests/Utils/TestModels/TestRSAKeyPair.swift Outdated Show resolved Hide resolved
@dscreve
Copy link
Author

dscreve commented Jan 29, 2025

I just committed a new version

dimitribouniol
dimitribouniol reviewed Jan 29, 2025
View reviewed changes
Tests/WebAuthnTests/Utils/TestModels/TestECCKeyPair.swift
static func signature(data: Data) throws -> P256.Signing.ECDSASignature {
let privateKey = try P256.Signing.PrivateKey(pemRepresentation: privateKeyPEM)
return try privateKey.signature(for: data)
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please drop this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTim 0xTim 0xTim requested changes

@dimitribouniol dimitribouniol dimitribouniol left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dscreve @dimitribouniol @0xTim