Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(handler): hide mullvad nodes from list #309

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

s0up4200
Copy link

I suspect this is just a bug and not intended behaviour. This is a simple fix that hides all the Mullvad nodes from the All machines list.

Tested on macOS v15.0.1 using VSCode v1.94.2

Fixes #278

@s0up4200 s0up4200 changed the title feat(handler): hide mullvad nodes from list fix(handler): hide mullvad nodes from list Oct 21, 2024
@gbraad
Copy link

gbraad commented Feb 2, 2025

they should probably be grouped or have a setting to hide them.

@s0up4200
Copy link
Author

s0up4200 commented Feb 2, 2025

they should probably be grouped or have a setting to hide them.

Are they even of any use here though? 🤔

@itsmatteomanf
Copy link

It would be probably a nice next step to allow hiding of non-SSH machines, too... Mullvad Nodes should just be hidden anyway, no need and no permissions to access them anyway.

@gbraad
Copy link

gbraad commented Feb 3, 2025

Are they even of any use here though? 🤔

Not at the moment; besides copy-paste to the command line to set as exit-node. The extension does not allow this. so yeah, ...

If The same logic for non-ssh would be applied; this can be prevented for all the nodes, including mullvad.

image

which prevents this message. Although, this is kinda helpful as it shows the node is at least "ONLINE", as this is how I also use the extension. Note; plus the address/name might allow other services to be accessed from the command line or simple browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mullvad exit-nodes show up in the "All machines" list
3 participants