-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CachingConverter
#35
base: main
Are you sure you want to change the base?
Conversation
9c1b46a
to
1c7c44a
Compare
51e3c1a
to
f1dad54
Compare
This reverts commit 1cc0f5d.
- strip the "management" part from the name(space) - move it into the "Converter" namespace - refine class/method names
b0cd2df
to
70601a4
Compare
Have you every thought about using the Symfony contracts for Caching: AFAIK, the callback would be our Converter call and the key has been already provided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some improvements for my old eyes ;-)
Yes, I thought about it, but I'm not sure if it's the best contract to depend upon. There are also PSR-6 and PSR-16 and I currently tend towards the latter. Symfony supports all three, so we are free to choose what suits us best. |
This is currently on hold until #41 is done. |
This re-adds the
CachingConverter
with an overhauled implementation which respects the context.Todo: