Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pimcore Numeric Editable uses string instead of int #40

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Pimcore Numeric Editable uses string instead of int #40

merged 1 commit into from
Jan 17, 2025

Conversation

mike4git
Copy link
Collaborator

@mike4git mike4git commented Jan 17, 2025 •
edited by jdreesen
Loading

For defaultValue a string has to be set.
So our NumericItem has to set the defaultValue with cast to string.

This is a followup of #39.

@mike4git @jdreesen
[Numeric uses string values] Internally Pimcore uses string in the Nu…
cf29565 
…meric Editable - so we have to cast it - but only in setDefaultValue
@jdreesen jdreesen force-pushed the bugfix/use-strings-for-internal-values-of-Numeric branch from 3004d72 to cf29565 Compare January 17, 2025 10:04
@jdreesen jdreesen changed the title Pimcore Numeric Editable uses string instead of int Pimcore Numeric Editable uses string instead of int Jan 17, 2025
@jdreesen jdreesen merged commit 7cd62f9 into main Jan 17, 2025
5 checks passed
@jdreesen jdreesen deleted the bugfix/use-strings-for-internal-values-of-Numeric branch January 17, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdreesen jdreesen jdreesen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mike4git @jdreesen