[Feature] Add PageExportController to bundle
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdreesen
reviewed
Jan 28, 2025
config/pimcore/routing.yml
Outdated
| @@ -0,0 +1,5 @@ | |||
| page_export: | |||
There was a problem hiding this comment.
It should be: neusta_pimcore_import_export_page_export
public/js/pimcore/exportPage.js
Outdated
Comment on lines
1
to
2
| // /Resources/public/js/exportPage.js | ||
|
|
There was a problem hiding this comment.
Useless comment (with wrong path).
Suggested change
| // /Resources/public/js/exportPage.js |
Comment on lines
44
to
16
| $event->setPaths(array_merge( | ||
| $event->getPaths(), | ||
| [ | ||
| '/bundles/neustatrinitypimcore/js/startup.js', | ||
| '/bundles/neustatrinitypimcore/js/exportPage.js', | ||
| ], | ||
| )); |
There was a problem hiding this comment.
Suggested change
| $event->setPaths(array_merge( | |
| $event->getPaths(), | |
| [ | |
| '/bundles/neustatrinitypimcore/js/startup.js', | |
| '/bundles/neustatrinitypimcore/js/exportPage.js', | |
| ], | |
| )); | |
| $event->addPaths([ | |
| '/bundles/neustapimcoreimportexport/js/exportPage.js', | |
| ]); |
There was a problem hiding this comment.
I've made a lot more changes to the Listener because most of the things we do not need and the directory naming was incorrect, too.
There was a problem hiding this comment.
But that doesn't mean we don't want this change, too.
jdreesen
changed the title
PageExportController to bundle
mike4git
force-pushed
the
feature/export-controller
branch
7 times, most recently
from
1f21dff to
9315278
Compare
|
Please also take a look at the hidden annotations:
|
mike4git
force-pushed
the
feature/export-controller
branch
from
9315278 to
71c9c41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By introducing this controller and other stuff we have a contextual menu for Documents: