Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Broken Link Checker #7022

Closed
wants to merge 2 commits into from

Conversation

JuanPabloDiaz
Copy link
Collaborator

@JuanPabloDiaz JuanPabloDiaz commented Jul 14, 2024

I am currently encountering an issue where the workflow is not automatically creating issues after running the script.

Upon reviewing the flagged broken links, it appears that many of them are related to cocUrl and cfpUrl. I believe it would be more effective to focus the checks exclusively on the url field. However, I am unsure how to implement this change.

Could someone please assist me with adjusting the script to only check the url field? Thank you!

commit 4627efc
Author: JuanPabloDiaz <[email protected]>
Date:   Sun Jul 14 11:52:56 2024 -0400

    ready

commit a1cfeb4
Author: Juan Diaz <[email protected]>
Date:   Sat Jul 6 12:21:02 2024 -0400

    Delete jsoncheck.yml

commit 75c5611
Author: JuanPabloDiaz <[email protected]>
Date:   Fri Jul 5 13:37:24 2024 -0400

    json

commit c06b1a8
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 21:11:04 2024 -0400

    url test #4

commit 62a9f30
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 20:58:13 2024 -0400

    testing PR

commit dc7c853
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 20:46:02 2024 -0400

    chore: Update branch name from test to main

commit 3c43860
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 20:38:54 2024 -0400

    Check links from PRs

commit a984731
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 17:11:30 2024 -0400

    false positives

commit f6962bf
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 17:03:34 2024 -0400

    Excluded urls

commit be80ddf
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 16:40:37 2024 -0400

    disable

commit 872d94c
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 16:40:08 2024 -0400

    conferences

commit 6e2b197
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 16:35:28 2024 -0400

    24, 25, 26

commit 1975aeb
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 16:27:44 2024 -0400

    json

commit 4411458
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 16:26:05 2024 -0400

    json

commit d7021ad
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 16:22:13 2024 -0400

    check links

commit 4984c76
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 16:02:22 2024 -0400

    Broken Link Checker
@JuanPabloDiaz JuanPabloDiaz requested a review from cgrail as a code owner July 14, 2024 16:05
@nimzco
Copy link
Member

nimzco commented Jul 14, 2024

I wonder if we could pass something like that as the input: 18162d9
| grep url ./conferences/2024/**/*.json

But it's a bit unclear to me given their documentation. And testing GitHub actions is always a pain 😭

@JuanPabloDiaz
Copy link
Collaborator Author

I found a simpler workflow that we could use instead (it is clean and easy to understand). I test it in one of my projects and it does the job.

I am not sure how to pass that as input.

@cgrail
Copy link
Member

cgrail commented Aug 14, 2024

I have created a new user and a token which can create issues for this repo. I have copied the PR to this repo and executed it directly here:
#7132

It seems to work now:
#7133

@cgrail
Copy link
Member

cgrail commented Aug 15, 2024

Replaced by: #7132

@cgrail cgrail closed this Aug 15, 2024
@JuanPabloDiaz JuanPabloDiaz deleted the links branch August 20, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants