Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links nimzco test #7024

Closed
wants to merge 2 commits into from
Closed

Links nimzco test #7024

wants to merge 2 commits into from

Conversation

nimzco
Copy link
Member

@nimzco nimzco commented Jul 14, 2024

From https://github.com/tech-conferences/conference-data/actions/runs/9929145100/job/27426327077?pr=7022
Test with grep url ./conferences/2024/**/*.json instead of the whole file

JuanPabloDiaz and others added 2 commits July 14, 2024 12:02
commit 4627efc
Author: JuanPabloDiaz <[email protected]>
Date:   Sun Jul 14 11:52:56 2024 -0400

    ready

commit a1cfeb4
Author: Juan Diaz <[email protected]>
Date:   Sat Jul 6 12:21:02 2024 -0400

    Delete jsoncheck.yml

commit 75c5611
Author: JuanPabloDiaz <[email protected]>
Date:   Fri Jul 5 13:37:24 2024 -0400

    json

commit c06b1a8
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 21:11:04 2024 -0400

    url test #4

commit 62a9f30
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 20:58:13 2024 -0400

    testing PR

commit dc7c853
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 20:46:02 2024 -0400

    chore: Update branch name from test to main

commit 3c43860
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 20:38:54 2024 -0400

    Check links from PRs

commit a984731
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 17:11:30 2024 -0400

    false positives

commit f6962bf
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 17:03:34 2024 -0400

    Excluded urls

commit be80ddf
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 16:40:37 2024 -0400

    disable

commit 872d94c
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 16:40:08 2024 -0400

    conferences

commit 6e2b197
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 16:35:28 2024 -0400

    24, 25, 26

commit 1975aeb
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 16:27:44 2024 -0400

    json

commit 4411458
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 16:26:05 2024 -0400

    json

commit d7021ad
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 16:22:13 2024 -0400

    check links

commit 4984c76
Author: JuanPabloDiaz <[email protected]>
Date:   Thu Jul 4 16:02:22 2024 -0400

    Broken Link Checker
@nimzco nimzco requested a review from cgrail as a code owner July 14, 2024 17:31
@cgrail
Copy link
Member

cgrail commented Aug 15, 2024

Doesn't work ony my machine:

lychee | grep url ./conferences/2024/**/*.json

Does it work on your machine? Do we still need this PR? I think I've fixed all current URLs so far.

@JuanPabloDiaz
Copy link
Collaborator

Does it work on your machine? Do we still need this PR? I think I've fixed all current URLs so far.

That's right, I believe we no longer need this PR. You've done an incredible job with the massive refactor, and everything seems to be working perfectly on my end (with the usual bugs on my machine, lol). @cgrail, if there's anything else you'd like help with or if there's a different area of the project where I can contribute more, please let me know. I'm eager to help out and continue learning!

I’ve been a bit busy over the past few weeks, but I’ve been keeping an eye on all the great work you’ve done. It's been impressive, and I’m looking forward to getting more involved again, especially in the UI repo.

@nimzco
Copy link
Member Author

nimzco commented Aug 22, 2024

Indeed! Amazing to see what you two have come up with! I'll close the PR!

@nimzco nimzco closed this Aug 22, 2024
@JuanPabloDiaz JuanPabloDiaz deleted the links-nimzco-test branch August 23, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants