Deprecation proposal: Block build-id as a search attribute #6494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shivs11
commented
Sep 6, 2024
| @@ -118,7 +122,9 @@ func (v *Validator) Validate(searchAttributes *commonpb.SearchAttributes, namesp | |||
| fmt.Sprintf("%s attribute can't be set in SearchAttributes", saFieldName), | |||
| ) | |||
| } | |||
|
|
|||
| if saFieldName == BuildIds { | |||
There was a problem hiding this comment.
We cannot reject all the predefined attributes, in a similar way system attributes are rejected, because there are some which are considered valid in requests. (For example - TemporalChangeVersion)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
WARNlevel for Search Attributes havingBuildIdsset.Why?
BuildIdsis a default SA and should not be set by the customer.How did you test it?
Potential risks
none, just a logging statement is being added for now.
Is hotfix candidate?
nope