Fix task state change for state based replication #6816
+129
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
reviewed
Nov 15, 2024
| ms.approximateSize += ai.Size() - prev.Size() | ||
| return nil | ||
| } | ||
| func (ms *MutableStateImpl) UpdateActivityTimerTaskStatus( |
There was a problem hiding this comment.
nit: let's add some comment on UpdateActivity() saying it ideally should not be used and if used, can only be used when user data needs to be changed. Same for UpdateUserTimer()
| ai.TimerTaskStatus = status | ||
| ms.updateActivityInfos[ai.ScheduledEventId] = ai | ||
| return nil | ||
| } | ||
|
|
||
| // UpdateActivityWithTimerHeartbeat updates an activity | ||
| func (ms *MutableStateImpl) UpdateActivityWithTimerHeartbeat( |
There was a problem hiding this comment.
this method needs to call UpdateActivityTimerTaskStatus as well.
Comment on lines
+209
to
+210
| updateActivityInfosUserDataUpdated map[int64]struct{} | ||
| updateTimerInfosUserDataUpdated map[string]struct{} |
There was a problem hiding this comment.
nit:
Suggested change
| updateActivityInfosUserDataUpdated map[int64]struct{} | |
| updateTimerInfosUserDataUpdated map[string]struct{} | |
| activityInfosUserDataUpdated map[int64]struct{} | |
| timerInfosUserDataUpdated map[string]struct{} |
There was a problem hiding this comment.
Plz also add some comment explaining why we need this in addition to updateActivityInfos and updateTimerInfos
| refreshUserTimerTask = true | ||
|
|
||
| // need to update user timer task mask for which task is generated | ||
| if err := mutableState.UpdateUserTimer( | ||
| timerInfo, | ||
| if err := mutableState.UpdateUserTimerTaskStatus( |
There was a problem hiding this comment.
I believe we have the same logic in this file for clearing activity timer task status, that needs to be updated as well.
| @@ -450,12 +450,12 @@ func (r *TaskRefresherImpl) refreshTasksForTimer( | |||
| } | |||
|
|
|||
| // clear timer task mask for later timer task re-generation | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add new api for updating timer task status
Why?
We need to distinguish the user data update and timer task status update because we don't need to update state transition when the change is task status update change.
How did you test it?
unit test
Potential risks
n/a
Documentation
n/a
Is hotfix candidate?
no