Refactoring: extract GetNextScheduledTime into a separate function #6817
+35
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ychebotarev
force-pushed
the
y_start_activity
branch
from
e5cd8f9
to
1465829
Compare
alexshtin
approved these changes
Nov 15, 2024
| @@ -169,3 +169,27 @@ func GetPendingActivityInfo( | |||
|
|
|||
| return p, nil | |||
| } | |||
|
|
|||
| func GetNextScheduleTime(ai *persistence.ActivityInfo) time.Time { | |||
There was a problem hiding this comment.
Suggested change
| func GetNextScheduleTime(ai *persistence.ActivityInfo) time.Time { | |
| func GetNextScheduledTime(ai *persistence.ActivityInfo) time.Time { |
pleease...
| // * in this case we should use current schedule time | ||
| // * this is a retry | ||
| // * next scheduled time will be calculated, based on the retry policy and last time when activity was completed | ||
| // * note - if delay interval was provided in the response it will be ignored |
| @@ -173,7 +173,8 @@ func updateActivityOptions( | |||
| // eventually matching service will call history service (recordActivityTaskStarted) | |||
| // history service will return error based on stamp. Task will be dropped | |||
|
|
|||
| err = mutableState.RegenerateActivityRetryTask(ai) | |||
| nextScheduleTime := workflow.GetNextScheduleTime(ai) | |||
There was a problem hiding this comment.
Suggested change
| nextScheduleTime := workflow.GetNextScheduleTime(ai) | |
| nextScheduledTime := workflow.GetNextScheduledTime(ai) |
alexshtin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Extract
GetNextScheduledTimeinto a separate function.Why?
RegenerateActivityRetryTask.How did you test it?
run tests
Potential risks
none
Is hotfix candidate?
no