-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scopes as array now throw Exception in getQueryStringParameter()
#1469
Comments
3.3. Access Token Scope
|
Hi @joelharkes - looking at this, I think it is just an oversight of mine where I didn't notice that validateScopes is no longer provided an array in the library. It probably should have been removed. It looks like removing this doesn't affect the code at all but is a breaking change so should probably be left as is for now. Apologies for any confusion caused there. If there is some wider implication of this change I'm not aware of, like causing a bug or something, please could you let me know and we can look at fixing this. Thank you |
Using a list of scopes was not spec compliant: thephpleague/oauth2-server#1469 With an update of our oauth lib this is no longer supported, leading to fails in the ATS: shopware/shopware#5986
Using a list of scopes was not spec compliant: thephpleague/oauth2-server#1469 With an update of our oauth lib this is no longer supported, leading to fails in the ATS: shopware/shopware#5986
The function
\League\OAuth2\Server\Grant\AbstractGrant::validateScopes()
allows an array of strings as input.Yet when it retrieves it from the
OauthRequest
viagetQueryStringParameter()
it does only allow scalar types and thus will fail:Whereas in older versions returning/setting scopes as an array
["scope1","scope2"]
was allowed.Now the source code is very confusing because on one hand it expects it can be an array, but on the other it doesn't allow an array 🤷.
sidenote: only
\League\OAuth2\Server\Grant\AuthCodeGrant::respondToAccessTokenRequest()
seems to allow scopes as array, all other references get the scope from query string and thus would fail.At least version 8.2.4 still allowed using strings.
The text was updated successfully, but these errors were encountered: