exchanges: Okx Update #1420
Open
exchanges: Okx Update #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into okx_update
… into okx_update
… into okx_update
… into okx_update
… into okx_update
… into okx_update
shazbert
requested changes
Nov 6, 2024
exchanges/okx/okx.go
Outdated
| if currency != "" { | ||
| params.Set("ccy", currency) | ||
| if !ccy.IsEmpty() { | ||
| params.Set("ccy", ccy.String()) | ||
| } | ||
| interval := ok.GetIntervalEnum(period, false) | ||
| if interval != "" { | ||
| params.Set("period", interval) | ||
| } | ||
| var resp [][6]string |
There was a problem hiding this comment.
This is not done like I suggested
shazbert
requested changes
Nov 7, 2024
shazbert
reviewed
Nov 10, 2024
shazbert
requested changes
Nov 11, 2024
exchanges/okx/okx.go
Outdated
Comment on lines
3521
to
3523
| // PlaceRecurringBuyOrder recurringorder.Buy.Lower()is a strategy for investing a fixed amount in crypto at order.Sell.Lower()s. | ||
| // An appropriate recurring approach in volatile markets allows you toorder.Buy.Lower()crypto at lower costs. order.Sell.Lower()re | ||
| // The API endpoints of Recurringorder.Buy.Lower()order.Sell.Lower()n. |
There was a problem hiding this comment.
Please revert all these comment changes across this file for order.Buy.Lower() and order.Sell.Lower()
shazbert
requested changes
Nov 11, 2024
|
Please also run tests with real/readonly/fake API keys. Panic on EG like my previous comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1420 +/- ##
==========================================
+ Coverage 37.13% 37.27% +0.13%
==========================================
Files 414 415 +1
Lines 180177 182943 +2766
==========================================
+ Hits 66910 68188 +1278
- Misses 105411 106898 +1487
- Partials 7856 7857 +1
|
|
Exchange_wrapper_standards is still having issues with the Okx authenticated requests not being set as Auth type, so they fail. Please message me if you need help |
shazbert
requested changes
Nov 14, 2024
| // ClosePositionForContractrid close position when the contract grid stop type is 'keep position'. | ||
| func (ok *Okx) ClosePositionForContractrid(ctx context.Context, arg *ClosePositionParams) (*ClosePositionContractGridResponse, error) { | ||
| // ClosePositionForContractrID close position when the contract grid stop type is 'keep position'. | ||
| func (ok *Okx) ClosePositionForContractrID(ctx context.Context, arg *ClosePositionParams) (*ClosePositionContractGridResponse, error) { |
There was a problem hiding this comment.
Suggested change
| func (ok *Okx) ClosePositionForContractrID(ctx context.Context, arg *ClosePositionParams) (*ClosePositionContractGridResponse, error) { | |
| func (ok *Okx) ClosePositionForContractID(ctx context.Context, arg *ClosePositionParams) (*ClosePositionContractGridResponse, error) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selam, ወንድሞች.
PR Description
This pull request incorporates modifications for the Okx exchange, encompassing changes to endpoint methods, rate limits, WebSocket subscriptions and handlers, wrapper functions, and conversion methods. Rigorous testing has been conducted on all facets of the functions to ensure their reliability. The code adheres to the GCT style standards, consistent with practices adopted by other exchanges. To enhance code quality, golangci-lint was utilized for linter testing, effectively rectifying a few errors. Furthermore, this implementation includes endpoint methods that the GCT wrapper did not initially support, ensuring compatibility for future use
The PR updated implementations for REST for trading and other endpoint methods, Web-socket streaming, and Trading through the web socket stream.
Fixes # (issue)
Type of change
Please delete options that are not relevant and add an
xin[]as the item is complete.How has this been tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and also, consider improving test coverage whilst working on a certain feature or package.
Checklist