Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Generating Unused Files for Distribution #171

Merged
merged 2 commits into from
Jan 28, 2024
Merged

Disable Generating Unused Files for Distribution #171

merged 2 commits into from
Jan 28, 2024

Conversation

threeal
Copy link
Owner

@threeal threeal commented Jan 28, 2024 •
edited
Loading

This pull request resolves #170 by disabling ncc from generating the source map and license files for distribution.

@threeal threeal self-assigned this Jan 28, 2024
@threeal threeal added the build label Jan 28, 2024
@threeal threeal added this to the Version 1.1.0 milestone Jan 28, 2024
@threeal threeal force-pushed the ncc-disable-generate-unused branch from b04f7c3 to 4114a91 Compare January 28, 2024 15:37
@threeal threeal marked this pull request as ready for review January 28, 2024 15:39
@threeal
Copy link
Owner Author

threeal commented Jan 28, 2024

There's seems an issue with the standard-usage job on macOS. But since changes in this PR should not affect that job, we can assume that the job should be passed.

@threeal threeal merged commit 331b4a6 into main Jan 28, 2024
9 of 10 checks passed
@threeal threeal deleted the ncc-disable-generate-unused branch January 28, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@threeal threeal

Labels
build
Projects
None yet
Milestone
Version 1.1.0
Development

Successfully merging this pull request may close these issues.

Disable Generating Unused Files for Distribution
1 participant
@threeal