ci(pgai): add format-fix, lint-fix and fix cmds to justfiles #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adolsalamanca
approved these changes
Feb 13, 2025
cevian
approved these changes
Feb 13, 2025
smoya
changed the title
smoya
commented
Feb 14, 2025
| @@ -65,12 +65,6 @@ USER root | |||
|
|
|||
| RUN pip install --break-system-packages uv==0.5.20 | |||
|
|
|||
| # install pgspot | |||
| RUN set -eux; \ | |||
There was a problem hiding this comment.
@jgpruitt Is there any reason I'm not aware of for building pgspot from source instead of installing as a dev dependency ?
smoya
commented
Feb 14, 2025
| @@ -30,6 +30,7 @@ dev = [ | |||
| "fastapi-cli==0.0.5", | |||
| "psycopg[binary]==3.2.1", | |||
| "uv==0.5.20", | |||
| "pgspot>=0.9.0", | |||
|
@adolsalamanca @cevian I made another round, please check the description of the PR with an updated list of the changes. 🙏 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just format-fixwill directly fix the formatting issues instead of showing the diff asjust formatdoes. Useful for development.just lint-fixwill do the same but for linting issues.just fixwill run both commands above.This PR also adds pgspot as dev dependency instead of building from source in Docker. Unless there is a specific reason, this alternative allows running pgspot from host machine and not only from the Docker container.