add locks in test_threads (#292)

timholy · Jan 25, 2024 · 65d049e · 65d049e
1 parent 56d1b66
commit 65d049e
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/test/test_threads.jl b/test/test_threads.jl
@@ -22,11 +22,14 @@
     prog = ProgressMeter.ProgressUnknown(desc="Attempts at exceeding trigger:")
     vals = Float64[]
     threadsUsed = Int[]
+    lk = ReentrantLock()
     Threads.@threads for _ in 1:1000
         !in(Threads.threadid(), threadsUsed) && push!(threadsUsed, Threads.threadid())
-        push!(vals, rand())
-        valssum = sum(vals)
-        if sum(vals) <= trigger
+        valssum = lock(lk) do
+            push!(vals, rand())
+            return sum(vals)
+        end
+        if valssum <= trigger
             ProgressMeter.next!(prog)
         elseif !prog.done
             ProgressMeter.finish!(prog)
@@ -47,8 +50,10 @@
     threadsUsed = Int[]
     Threads.@threads for _ in 1:100000
         !in(Threads.threadid(), threadsUsed) && push!(threadsUsed, Threads.threadid())
-        push!(vals, -rand())
-        valssum = sum(vals)
+        valssum = lock(lk) do
+            push!(vals, -rand())
+            return sum(vals)
+        end
         if valssum > thresh
             ProgressMeter.update!(prog, valssum)
         else