Better support for emoji with zero width connectors #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmdvs
changed the title
tmdvs
commented
Oct 19, 2024
| @@ -9,7 +9,7 @@ import ( | |||
|
|
|||
| // SearchResult - Occurrence of an emoji in a string | |||
| type SearchResult struct { | |||
| Match interface{} | |||
There was a problem hiding this comment.
This should have never been an interface, it leads to unnecessary type conversion/checking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zero-width connector is a special character used to combine multiple emoji into a single emoji character on screen. For example 👩👩👧👧
This patches the code to skip specific instances of the zero-width connector to avoid parsing parts of the emoji as unicode characters/breaking into multiple emoji.
This is based on #12 (comment)