[BUGFIX] Fix showing "Scheduled" and "Run-time" columns in backend log #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Would you mind updating the PHPStan baseline, so that it runs green again. Would this also apply for 12.0.x releases? I sort of had decided to not do anymore bug fixes for the 11.x branch as TYPO3 11 it ELTS now. |
cweiske
force-pushed
the
empty-logfields
branch
from
3f8d1b3 to
ce71f35
Compare
In Info > Site Crawler > Crawler log: As soon as the backend user activated the "Show Result Log" checkbox one time, the columns "Scheduled" and "Run-time" are empty when the checkbox is disabled. The reason is that the variable's value is not taken into account, only its existence in the user session data.
cweiske
force-pushed
the
empty-logfields
branch
from
ce71f35 to
e292c9e
Compare
No, the backend log view had been rewritten in 2022 with commit 0e7d7e2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Info > Site Crawler > Crawler log:
As soon as the backend user activated the "Show Result Log" checkbox one time, the columns "Scheduled" and "Run-time" are empty when the checkbox is disabled.
The reason is that the variable's value is not taken into account, only its existence in the user session data.
Description
I have