Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Try updating xbean-asm #199

Draft
wants to merge 7 commits into
base: tomee-1.7.x-TT.x-release
Choose a base branch
from

Conversation

jgallimore
Copy link
Member

This attempts to upgrade the version of xbean-asm to a recent version to allow jars with module-info to be scanned. This version of TomEE is old, and so OWB still brings in an older version of xbean-asm, so jars with module-info may still fail.

@jgallimore jgallimore marked this pull request as draft June 7, 2022 13:32
pom.xml Outdated
@@ -1636,6 +1636,10 @@
<groupId>commons-pool</groupId>
<artifactId>commons-pool</artifactId>
</exclusion>
<exclusion>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, these shaded jars change the relocated package so usages of org.apache.xbean.asm5 become org.apache.xbean.asm9 in the code. The version of OpenWebBeans in use in this version of TomEE still uses ASM5, so we'd either need to patch that version of OWB to use ASM9, or continue to use both (assuming that works).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version of OpenWebBeans in use in this version of TomEE still uses ASM5, so we'd either need to patch that version of OWB to use ASM9, or continue to use both (assuming that works).

yesterday I executed the test locally on one open-ejb related module from this PR and test passes, I guess I was lucky so I decided to move with CI for getting the full picture. But yes, the package in OWB changed :( .

@cesarhernandezgt
Copy link
Member

test this please.

@cesarhernandezgt
Copy link
Member

test this please.

@cesarhernandezgt
Copy link
Member

We were getting inconsistencies between CI resuls for 1.7.6-TT.28 and this PR because the PR was based on OS 1.7.6 and not on 1.7.6-TT.28. The result for c65d683 would be the ones that we can compare between Before and After CI results.

@cesarhernandezgt
Copy link
Member

test this please.

@cesarhernandezgt
Copy link
Member

This PR gest +25 failures than tomee-1.7.x-TT.x-release branch. I see errors like:

SEVERE: Error deploying JAX-WS Web Service for EJB HelloWS
java.lang.RuntimeException: No ASM ClassWriterFound
Caused by: java.lang.ClassNotFoundException: org.objectweb.asm.ClassWriter
Jun 09, 2022 5:17:09 PM org.apache.cxf.jaxws.WrapperClassGenerator createWrapperClass
WARNING: {http://jaxws.tests.arquillian.openejb.apache.org/}hirequires a wrapper bean but problems with ASM has prevented creating one.  Operation may not work correctly.
Jun 09, 2022 5:17:09 PM org.apache.cxf.jaxws.WrapperClassGenerator createWrapperClass

So open-jpa 2.4.3 also brings xbean-asm6-shaded jars

 --- maven-dependency-plugin:2.10:tree (default-cli) @ arquillian-tomee-jaxws-tests ---
[INFO] org.apache.openejb:arquillian-tomee-jaxws-tests:jar:1.7.6-TT.28
[INFO] \- org.apache.openejb:openejb-core:jar:4.7.6-TT.28:compile
[INFO]    +- org.apache.xbean:xbean-asm9-shaded:jar:4.21:compile
[INFO]    +- org.apache.xbean:xbean-finder-shaded:jar:4.21:compile
[INFO]    +- org.apache.xbean:xbean-reflect:jar:4.21:compile
[INFO]    +- org.apache.xbean:xbean-naming:jar:4.21:compile
[INFO]    +- org.apache.xbean:xbean-bundleutils:jar:4.21:compile
[INFO]    \- org.apache.openjpa:openjpa:jar:2.4.3:compile
[INFO]       \- org.apache.xbean:xbean-asm6-shaded:jar:4.8:compile

So based on the above it seems we need to patch open-jpa 2.4.3 to use asm9 instead of asm6, release it and test again this PR bu using open-jpa 2.4.3-T.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants