Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support verifying URL for Gitlab #3113

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

DarkaMaul
Copy link

Support GitLab.io Pages URL verification

warehouse/oidc/models/_core.py Outdated Show resolved Hide resolved
tests/unit/oidc/models/test_gitlab.py Outdated Show resolved Hide resolved
warehouse/oidc/models/gitlab.py Show resolved Hide resolved
warehouse/oidc/models/gitlab.py Outdated Show resolved Hide resolved
Copy link

@facutuesca facutuesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one final suggestion

warehouse/oidc/models/_core.py Outdated Show resolved Hide resolved
warehouse/oidc/models/github.py Outdated Show resolved Hide resolved
warehouse/oidc/models/gitlab.py Outdated Show resolved Hide resolved
tests/unit/oidc/models/test_core.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants