Created a temporary background transparent blue color for checkboxes #8363
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added transparent blue background colors for checkbox hover states in both light and dark themes, with different opacities to maintain visual consistency across modes.
- Modified hover background in
packages/twenty-ui/src/input/components/Checkbox.tsxto usetheme.background.transparent.blueinstead oftheme.color.blue10 - Added transparent blue with 0.2 opacity in dark theme (
BackgroundDark.ts) and 0.08 opacity in light theme (BackgroundLight.ts) - Implemented different opacity values (0.2 vs 0.08) to account for contrast differences between dark and light modes
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -22,6 +22,7 @@ export const BACKGROUND_DARK = { | |||
| light: RGBA(GRAY_SCALE.gray0, 0.06), | |||
| lighter: RGBA(GRAY_SCALE.gray0, 0.03), | |||
| danger: RGBA(COLOR.red, 0.08), | |||
| blue: RGBA(COLOR.blue, 0.2), | |||
There was a problem hiding this comment.
style: Blue transparency (0.2) is significantly higher than light theme (0.08). Consider matching for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a temporary background transparent blue color for checkboxes