Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AB-1 fix: Change the light icon button color back to tertiary #8504

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aushwin
Copy link

@aushwin aushwin commented Nov 14, 2024

Description

Screenshots
Screenshot 2024-11-14 at 10 10 16 PM

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Changed the default accent color of LightIconButton from 'secondary' to 'tertiary' to match design requirements for Domain, phone, and email inputs.

  • Modified packages/twenty-ui/src/input/button/components/LightIconButton.tsx to use tertiary font color as default accent
  • Change affects appearance of Domain, phone, and email input buttons per Figma design specs

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

github-actions bot commented Nov 14, 2024

Welcome!

Hello there, congrats on your first PR! We're excited to have you contributing to this project.
By submitting your Pull Request, you acknowledge that you agree with the terms of our Contributor License Agreement.

Generated by 🚫 dangerJS against b2855d6

@FelixMalfait
Copy link
Member

Hey @aushwin thanks! We want to change not the default value but the value in the specific contexts that are mentioned in the issue. cc @Bonapara

@Bonapara
Copy link
Member

Hi @aushwin, thanks for the PR! We should keep the default color of Light Icon Buttons to Secondary but apply the Tertiary variant in the specified locations. Does it make sense?

@aushwin
Copy link
Author

aushwin commented Nov 14, 2024

@Bonapara @FelixMalfait My Bad, will make the correction 😀

@aushwin
Copy link
Author

aushwin commented Nov 14, 2024

@Bonapara Could you take a look and let me know if the approach I've implemented is viable? I’ll apply it to the rest if it’s good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phone, Email, Domain input Light Icon Button color change
3 participants