Modal Background & box shadow fixes #8506
Open
+14
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Modified overlay colors in the dark theme to improve visibility by lightening the base color while maintaining existing opacity levels.
- Changed overlay base color from
GRAY_SCALE.gray90toGRAY_SCALE.gray80in/packages/twenty-ui/src/theme/constants/BackgroundDark.tsfor primary (0.8 opacity) and secondary/tertiary (0.4 opacity) overlays
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+27
to
+28
| overlaySecondary: RGBA(GRAY_SCALE.gray80, 0.4), | ||
| overlayTertiary: RGBA(GRAY_SCALE.gray80, 0.4), |
There was a problem hiding this comment.
style: overlaySecondary and overlayTertiary use identical values - consider using a single constant if they're meant to be the same
Bonapara
changed the title
Weiko
reviewed
Nov 14, 2024
| }>` | ||
| display: flex; | ||
| flex-direction: column; | ||
| box-shadow: ${({ theme }) => theme.boxShadow.superHeavy}; |
There was a problem hiding this comment.
You probably forgot to remove that line after implementing the variant below 🙂(this will be most likely overwritten by the duplicated rule but let's remove this line for clarity)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After