Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim quotes and whitespace from search bar text #725

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Trim quotes and whitespace from search bar text #725

merged 2 commits into from
Nov 13, 2024

Conversation

adhityamamallan
Copy link
Contributor

@adhityamamallan adhityamamallan commented Nov 12, 2024 •
edited
Loading

Summary

  • Add new param searchTrimRegExp to PageFilters that allows the search bar to prune all matches before setting the search query param
  • Prune quotes and whitespaces by default

Test plan

Updated unit tests + ran locally.

@Assem-Uber Assem-Uber merged commit 9d8e758 into uber:release/4.0.0 Nov 13, 2024
4 checks passed
@adhityamamallan adhityamamallan deleted the trim-search branch November 13, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Assem-Uber Assem-Uber Assem-Uber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adhityamamallan @Assem-Uber