Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(extensions): migrate to createRuleTestCaseFunction #183

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

marcalexiei
Copy link

Follow up of #176.

extensions rule right now has two messages:

messages: {
missing: 'Missing file extension {{extension}}for "{{importPath}}"',
unexpected:
'Unexpected use of file extension "{{extension}}" for "{{importPath}}"',
},

missing message is populate here:

messageId: 'missing',
data: {
extension: extension ? `"${extension}" ` : '',
importPath: importPathWithQueryString,
},

However testing this message with extensiondata property set like extension: '"js" ':

test({
  code: '...'
  errors: [
    { messageId: 'missing', data: { extension: '"js" ', importPath: './foo'  } }
  ]
})

Seems a bit awkward IMHO.


To simplify extension data property I added a separate message missingKnown.

I also refined Options type.

Copy link

changeset-bot bot commented Nov 14, 2024

⚠️ No Changeset found

Latest commit: 7dc3480

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Collaborator

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@SukkaW SukkaW merged commit 14fc608 into un-ts:master Nov 15, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants