fix(no-duplicates): merge type import as with value import
#204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f17bfdb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
privatenumber
changed the title
no-duplicates auto-fix bugno-duplicates): merge type import as with value import
SukkaW
reviewed
Dec 17, 2024
|
Was the CI supposed to release it? Looks like it didn't |
The changeset action will create a release PR (the current one is #202). I will merge that to make a new release! |
|
Ah I see. I appreciate it, thank you! |
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Dec 17, 2024
##### [v4.5.1](https://github.com/un-ts/eslint-plugin-import-x/blob/HEAD/CHANGELOG.md#451) ##### Patch Changes - [#198](un-ts/eslint-plugin-import-x#198) [`ac6d2e1`](un-ts/eslint-plugin-import-x@ac6d2e1) Thanks [@voxpelli](https://github.com/voxpelli)! - Fix [#197](un-ts/eslint-plugin-import-x#197) with missing types - [#204](un-ts/eslint-plugin-import-x#204) [`32e9b55`](un-ts/eslint-plugin-import-x@32e9b55) Thanks [@privatenumber](https://github.com/privatenumber)! - fix type-import and value-import merging when import-as is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug when merging a type-import with a value-import, when the type import uses
import-assyntax.This handles the
import-ascase.