Rewrite the onboarding feature #4
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acquitelol
force-pushed
the
onboarding
branch
2 times, most recently
from
cc849a0 to
6a5dd91
Compare
To test this, execute `window.meow()` (aha)
So that it actually appears at all, loading instantly or with no timeout will not work Also remove unused manager import in constants.ts
* Use the global Navigation module instead of the Modal module * Use Discord's getHeaderCloseButton instead of making a custom one * Minor cleanups
acquitelol
force-pushed
the
onboarding
branch
from
6a5dd91 to
82591e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an ongoing attempt to rewrite the old Onboarding system.
Main goals:
Use Discord's stepped modals to prevent requiring a patch of the- Done! ✨LaunchPadContainercomponent to display our onboarding.protocolspart as that has long been removed from the clientCurrent priority: (will be updated as the PR progresses)