-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-18280 Add time zone offset symbol that doesn't use gmtZeroFormat #4347
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as spam.
This comment was marked as spam.
I don't see mention of the new pattern symbol here. |
It's in the table, with the other ones |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no explanation of "justified" in the table (2293). It only occurs further up in the spec. So when someone is looking at the table (2293), they will not know what that means. And it isn't really explained on line 1709. This needs a short sentence explaining the terminology in both places, eg so that a column of timezone offsets has roughly the same width in each line.
(Side note: justified has multiple meanings in English, including https://en.wikipedia.org/wiki/Justified_(TV_series))
The other formats also aren't really explained in that paragraph. Would you prefer "fixed-length" over "justified"? Also, why are the "jira-ticket" and "single-commit" checks failing? |
Yes, I think fixed-length would be better, and that doesn't need a gloss.
@srl295 Any thoughts? |
gmtZeroFormat
I thought it might be due to characters in the title. I've seen it if you have extra dashes before, but I tried removing a few and it didn't fix it. |
Yes, I recall that also. I try to stick to just ASCII letters and digits.
…On Fri, Feb 7, 2025, 19:00 Annemarie Apple ***@***.***> wrote:
I thought it might be due to characters in the title. I've seen it if you
have extra dashes before, but I tried removing a few and it didn't fix it.
—
Reply to this email directly, view it on GitHub
<#4347 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMANLB5IJ5PTTGXSC732OVXL3AVCNFSM6AAAAABWTCNXHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBUGQ2TEMZSGU>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Brought to you by the Unicode people 😅 |
#😶🌫️ I meant to say: |
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
@@ -1706,12 +1706,16 @@ Note: A generic location format is constructed by a part of time zone ID represe | |||
* "UTC-3" (short) | |||
* "Гринуич+03:30" (long) | |||
|
|||
Otherwise (when the offset from GMT is zero, referring to GMT itself) the style specified by the `<gmtZeroFormat>` element is used: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I don't agree with the assumption that a zero GMT offset refers to GMT itself. Azores Summer Time is GMT+0, but that doesn't make it GMT, it's still Azores Summer Time, just with a GMT offset of zero. I would actually prefer if this format never used the gmtZeroFormat
and we wouldn't need to introduce a new format for this behaviour.
CLDR-18280
ALLOW_MANY_COMMITS=true