Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-18280 Add time zone offset symbol that doesn't use gmtZeroFormat #4347

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

robertbastian
Copy link
Member

CLDR-18280

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@jira-pull-request-webhook

This comment was marked as spam.

@robertbastian robertbastian marked this pull request as ready for review February 6, 2025 09:43
@robertbastian robertbastian removed their assignment Feb 6, 2025
@macchiati
Copy link
Member

I don't see mention of the new pattern symbol here.

@robertbastian
Copy link
Member Author

It's in the table, with the other ones

Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no explanation of "justified" in the table (2293). It only occurs further up in the spec. So when someone is looking at the table (2293), they will not know what that means. And it isn't really explained on line 1709. This needs a short sentence explaining the terminology in both places, eg so that a column of timezone offsets has roughly the same width in each line.

(Side note: justified has multiple meanings in English, including https://en.wikipedia.org/wiki/Justified_(TV_series))

@robertbastian
Copy link
Member Author

The other formats also aren't really explained in that paragraph.

Would you prefer "fixed-length" over "justified"?

Also, why are the "jira-ticket" and "single-commit" checks failing?

@macchiati
Copy link
Member

Yes, I think fixed-length would be better, and that doesn't need a gloss.

  • I don't know why "Pull request title must start with a Jira ticket ID" is failing. Looks like you do that.
  • I don't recall seeing "This PR has undefined commits; consider squashing:" before. Or maybe my gaze just passes over it, because I don't think either of these block merging.
  • The "@github-actions cldr-mvn / build (pull_request) Failing after 3m" is very odd; not sure why CheckArchive is called and failing.

@srl295 Any thoughts?

@AEApple AEApple changed the title CLDR-18280 Add time zone offset symbol that doesn't use gmtZeroFormat CLDR-18280 Add time zone offset symbol that doesn't use gmtZeroFormat Feb 8, 2025
@AEApple
Copy link
Contributor

AEApple commented Feb 8, 2025

I thought it might be due to characters in the title. I've seen it if you have extra dashes before, but I tried removing a few and it didn't fix it.

@macchiati
Copy link
Member

macchiati commented Feb 8, 2025 via email

@robertbastian
Copy link
Member Author

I try to stick to just ASCII letters and digits.

Brought to you by the Unicode people 😅

@macchiati
Copy link
Member

I try to stick to just ASCII letters and digits.

Brought to you by the Unicode people 😅

#😶‍🌫️

I meant to say:
with ASCII, I stick to just letters and digits — meaning avoid ASCII punctuation, because they sometimes trigger weird behavior in GitHub commit messages and branch names.

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • docs/ldml/tr35-dates.md is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@robertbastian robertbastian changed the title CLDR-18280 Add time zone offset symbol that doesn't use gmtZeroFormat CLDR-18280 Add time zone offset symbol that does not use gmtZeroFormat Feb 10, 2025
@robertbastian robertbastian changed the title CLDR-18280 Add time zone offset symbol that does not use gmtZeroFormat CLDR-18280 Add time zone offset symbol that doesn't use gmtZeroFormat Feb 10, 2025
@@ -1706,12 +1706,16 @@ Note: A generic location format is constructed by a part of time zone ID represe
* "UTC-3" (short)
* "Гринуич+03:30" (long)

Otherwise (when the offset from GMT is zero, referring to GMT itself) the style specified by the `<gmtZeroFormat>` element is used:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I don't agree with the assumption that a zero GMT offset refers to GMT itself. Azores Summer Time is GMT+0, but that doesn't make it GMT, it's still Azores Summer Time, just with a GMT offset of zero. I would actually prefer if this format never used the gmtZeroFormat and we wouldn't need to introduce a new format for this behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants