Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(azure-drivers): add managed identity client ID support #584

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

itpropro
Copy link
Member

Enhance Azure drivers to support user-assigned managed identity authentication by adding an optional managedIdentityClientId parameter. This allows choosing the correct user assigned managed identity to use.

Changes:

  • Added managedIdentityClientId option to driver interfaces to use with DefaultAzureCredential if provided
  • Improved authentication flexibility for Azure services
  • Fixing a bug with CosmosDB syntax that changed that didn't came up due to disabled test suites
  • Fixed removeItem throws in CosmosDB driver
  • Improved stability of Key Vault and it's test suite by introducing a wait of 750ms (average time to purge) only after clean if purge is provided
  • Added a parameter to disablePurging for Key Vaults with enabled purge protection

All changes are tested against the local emulator (if available) and live Azure resources.

@itpropro itpropro requested a review from pi0 as a code owner January 29, 2025 01:58
Copy link

cloudflare-workers-and-pages bot commented Jan 29, 2025

Deploying unstorage with  Cloudflare Pages  Cloudflare Pages

Latest commit: 50a60ab
Status: ✅  Deploy successful!
Preview URL: https://2897dcb3.unstorage.pages.dev
Branch Preview URL: https://feat-azure-authentication.unstorage.pages.dev

View logs

@pi0
Copy link
Member

pi0 commented Jan 29, 2025

Appreciate the PR but please consider splitting changes next times, it is clearly written in PR template.

  1. Please keep your changes minimal and split them if you need to.

@itpropro
Copy link
Member Author

Appreciate the PR but please consider splitting changes next times, it is clearly written in PR template.

  1. Please keep your changes minimal and split them if you need to.

I can of course split this, the errors just occured "on accident" when running the test suites and for the changes to be validated properly, I needed the test suites to be representative.
It's no problem to split out the the fixes separately if you want, just wanted to save you the review work :)

@pi0
Copy link
Member

pi0 commented Jan 29, 2025

no worries on this one is good 👍🏼 (sorry might be back on this with some delay)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants