Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
It seems that a similar change was accepted recently #14 but was then reverted in #16 (reason unclear). This has lead to the issue described in #20. I think both the stateful set selector labels and the service selector labels should just always take the same value as the pod labels to avoid future issues. Happy to discuss in more detail if required.
PR Type
Bug fix, Enhancement
Description
podLabels
instead ofselectorLabels
to ensure consistency and avoid future issues.selectorLabels
configuration fromvalues.yaml
.Changes walkthrough 📝
service.yaml
Update service selector to use pod labels
charts/vespa/templates/service.yaml
labels.
statefulset.yaml
Update stateful set selector to use pod labels
charts/vespa/templates/statefulset.yaml
selector labels.
values.yaml
Remove selectorLabels and use podLabels in configurations
charts/vespa/values.yaml
selectorLabels
and updated configurations to usepodLabels
.