Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding themeService #350

Merged
merged 6 commits into from
Oct 19, 2023
Merged

feat: Adding themeService #350

merged 6 commits into from
Oct 19, 2023

Conversation

nickrandolph
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

Have to manually add reference to uno.extensions.core.winui

What is the new behavior?

REference to uno.extensions.core.winui is already added to the project

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this only adds some PackageReferences. What APIs should be used from this package? Could there be some C# code added to the template showing how to do it? (even if the code is commented out)

@nickrandolph
Copy link
Contributor Author

There will be but for now we need the package references for simplecalc

@nickrandolph nickrandolph merged commit fa2a8f1 into main Oct 19, 2023
38 checks passed
@nickrandolph nickrandolph deleted the dev/nr/issue349 branch October 19, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants