Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Disabling (again) trimming on windows #356

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

nickrandolph
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Trimming has been causing a number of issues eg:

  • ImmutableList failing to serialise
  • Converters not able to cast from bool to Visibility

What is the new behavior?

Trimming has been commented out (both in debug and release) to avoid issues arising unexpected.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph merged commit 37cfae9 into main Oct 23, 2023
38 checks passed
@nickrandolph nickrandolph deleted the dev/nr/disabletrimming branch October 23, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants