Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable meteor 3 compatibility by adding specific versions of caching-compiler #188

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

vparpoil
Copy link
Contributor

Caching-compiler has been bumped to 2.0.0 within Meteor 3. This change allows to add the plugin and avoids encounter the following error :

=> Errors while adding packages:             
                                              
While selecting package versions:
error: Conflict: Constraint [email protected] is not satisfied by caching-compiler 2.0.0-alpha300.18.
Constraints on package "caching-compiler":
* caching-compiler@~2.0.0-alpha300.18 <- top level
* [email protected] <- caching-html-compiler 2.0.0-alpha300.17 <- static-html 1.3.3-alpha300.18
* [email protected] <- coffeescript 2.7.0
* [email protected] <- universe:i18n 2.1.0
Tested with [email protected]

Following this PR : #185 I have proposed a new version with several possible versions of caching-compiler : 1.2.2 (original one), 2.0.0-beta300.6 (one actually published as of today), 2.0.0 (to be published when v3 goes live I guess)

@vparpoil vparpoil mentioned this pull request Mar 12, 2024
@zendranm
Copy link
Member

zendranm commented Mar 22, 2024

@vparpoil After reconsidering the matter, we decided not to bump the version of the caching-compiler until Meteor 3 is officially released. Your changes should work, but only until the new beta version of the caching-compiler is released. Since we don't want to bump it every time a new beta is published, we decided to revisit that after the official release.

If this is something you urgently need in your project, I'd suggest to fork this project and use it locally with your changes. To do that, you'll just need to add this project to the packages directory of your project and install it as you would normally do, as described here.

@brianlukoff
Copy link

Now that Meteor 3 is out, would it be possible to publish this as an official release?

@MaxTwentythree
Copy link

Hello,

first, thank you for this great package!

I would also be very interested to know when this will be merged.
I really need the v3 update to finally be able to leave node 14 and this package is the last one not compatible..

Thanks and Cheers

@piotrpospiech
Copy link
Contributor

Hi, thanks for your patience. We will publish a new version that supports Meteor v3 tomorrow.

@zendranm
Copy link
Member

Tested with Meteor 2.16 and 3.0.1. Looks good to me.

@zendranm zendranm self-assigned this Jul 25, 2024
@zendranm zendranm merged commit c83885f into vazco:master Jul 25, 2024
3 checks passed
@zendranm
Copy link
Member

We just published the 3.0.0 version that supports Meteor v3.

@MaxTwentythree
Copy link

Thank you, that's perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants