-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RSDK-7322] Move analog writers from Board interface to Analog interface #3916
Conversation
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, I don't have an analog writer but you could test with a fake board.
c5b7ca9
to
4671164
Compare
I was unable to get the fake board to work. On closer inspection, it's because |
…ace (#3916) Everything compiles, the linter is happy, and the fake board works. but that's as far as I've tested; I don't have an analog writer to try this out with.
Everything compiles and the linter is happy, but that's as far as I've tested; I don't have an analog writer to try this out with. Olivia, maybe I could borrow one from you?