Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSDK-7322] Move analog writers from Board interface to Analog interface #3916

Merged
merged 12 commits into from
May 8, 2024

Conversation

penguinland
Copy link
Member

Everything compiles and the linter is happy, but that's as far as I've tested; I don't have an analog writer to try this out with. Olivia, maybe I could borrow one from you?

@penguinland penguinland requested a review from oliviamiller May 7, 2024 18:57
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label May 7, 2024
Copy link
Contributor

github-actions bot commented May 7, 2024

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base IsMoving
board GPIOPinByName
camera Properties
encoder Properties
motor IsMoving
sensor Readings
servo Position
arm EndPosition
audio MediaProperties
gantry Lengths
gripper IsMoving
input_controller Controls
movement_sensor LinearAcceleration
power_sensor Power
pose_tracker Poses
motion GetPose
vision ClassificationsFromCamera

Copy link
Member

@oliviamiller oliviamiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I don't have an analog writer but you could test with a fake board.

components/board/client.go Outdated Show resolved Hide resolved
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels May 7, 2024
@penguinland penguinland force-pushed the analog_write_move branch from c5b7ca9 to 4671164 Compare May 8, 2024 18:26
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels May 8, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels May 8, 2024
@penguinland
Copy link
Member Author

I was unable to get the fake board to work. On closer inspection, it's because analogTestPin was the empty string, if you use any other pin it throws away any written value when you read it, and if you try to use that pin it complains that the pin can't be the empty string. So, I made the test pin "1", and then things work great (for this one pin; others continue throwing away the written values any time you try reading it). I still have doubts that having different behavior on analogTestPin is a good idea or that throwing away written values on any pin is a good idea, but those are questions for another day.

@penguinland penguinland merged commit d3f3bff into viamrobotics:main May 8, 2024
16 checks passed
@penguinland penguinland deleted the analog_write_move branch May 8, 2024 20:00
vijayvuyyuru pushed a commit that referenced this pull request May 9, 2024
…ace (#3916)

Everything compiles, the linter is happy, and the fake board works. but that's as far as I've tested; I don't have an analog writer to try this out with.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants